Support batch input for median_filter2d #288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mainak431 Hi, would you mind taking a look? |
|
@WindQAQ Thanks for the excellent contribution. Everything looks pretty fine. |
Squadrick
approved these changes
Jun 16, 2019
|
@Mainak431 Here is the example colab notebook. I will include this in addon's example in maybe the next PR. |
|
Nice contribution.
…On Sun 16 Jun, 2019, 10:20 PM Tzu-Wei Sung, ***@***.***> wrote:
@Mainak431 <https://github.com/Mainak431> Here is the example colab
notebook
<https://colab.research.google.com/drive/1ZOAFTRdxKYDBpG75ZITukIr8MjUR2qDA>.
I will include this in addon's example in maybe the next PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#288?email_source=notifications&email_token=AIRDMQVU3QCXZFC6XXLN4STP2ZVPDA5CNFSM4HYLJF6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXZQ3MI#issuecomment-502468017>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIRDMQT2RQ7ED3MIX6IELALP2ZVPDANCNFSM4HYLJF6A>
.
|
|
@WindQAQ Thanks for the contribution. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #230. Also meets the interface of mean_filter2d.
A general random test case is down below. Maybe there are some ways to speed up. It's now much more slower than scipy's implementation even for the input of shape [1, h, w, 1].
https://colab.research.google.com/drive/1UkNXxjTMHifKmHB2N5ojOHFojtXrOUIG