-
Notifications
You must be signed in to change notification settings - Fork 614
Convert unknown rank image to 4D image #330
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Convert unknown rank image to 4D image #330
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good and is a nice cleanup of the image code. My only question before merging is whether we need to be more explicit about what assumptions we're making regarding the input shape. E.g., do we need to say in docstrings that we explicitly support (N, H, W, C), (H, W, C), and (H, W) inputs and assume that channel (if present) is last? Maybe we can assume the user knows some of this, but it might be good to be explicit in the docstrings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM. Thank you, Facai! May related to #320 (docstring)
61463a0
to
eaf339e
Compare
@kyleabeauchamp Good question, Kyle, I didn't notice that. I think @WindQAQ It's wired that I find all tests pass without tf.control_dependencies. For safety, I have add the op as suggested :-) All comments has been solved, can you take a look again, Kyle and Tzu-Wei? |
@facaiy thank you! @kyleabeauchamp, Kyle, feel free to merge this after taking a look. |
Forget to mention: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix #243
*_4D_image
looks kind of confusing, any good idea?