-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Update to enable python 3.9 building on Linux #1314
Conversation
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
.github/workflows/build.yml
Outdated
- os: ubuntu-18.04 | ||
python: '3.9' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yongtang is there a reference for this unstable combination?
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
@kvignesh1420 to explain a little about the GitHub Actions setup: Previously when we do testing (when Ubuntu 20.04 was not released yet), we use 18.04 as the default test machine and test again 3.5, 3.6, 3.7. Because 18.04 does not comes with 3.5 and 3.7, we installed After ubuntu20.04 was out, we used ubuntu 20.04's system python 3.8 to test 3.8 as well. At that time, we use a matrix of (Ubuntu 18.04 + 20.04) x (python 3.6 + 3.7 + 3.8). However, GitHub Actions was not smart enough so we have to exclude several duplicate combinations (Ubuntu 18.04+3.8, Ubuntu 20.04+3.6, Ubuntu 20.04+3.7 was excluded. That is why you see the line of Now I take a look at the workflow again, and realized that actually python3.6, python 3.7, python 3.8, python 3.9 are all available on ubuntu 20.04 (either from system default python 3.8, or deadsnake PPA's 3.6, 3.7). For that reason looks like we don't need ubuntu 18.04 at all. From the above I updated the script again and pushed the PR. Please take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the info @yongtang.
* Update to enable python 3.9 building on Linux Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Switch to always use ubuntu:20.04 Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
* Update to enable python 3.9 building on Linux Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Switch to always use ubuntu:20.04 Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Since tf-nightly 3.9 is available on Linux, this PR enables our testing for python 3.9 (Linux only)
Signed-off-by: Yong Tang yong.tang.github@outlook.com