Shareability: re-arrange metrics state order #6224
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmd3k
approved these changes
Mar 9, 2023
| @@ -161,14 +161,13 @@ export type CardToPinnedCard = Map<NonPinnedCardId, PinnedCardId>; | |||
| export type PinnedCardToCard = Map<PinnedCardId, NonPinnedCardId>; | |||
|
|
|||
| export interface MetricsNamespacedState { | |||
| /* | |||
| * Date-related states: states below are drived from the server. | |||
There was a problem hiding this comment.
Date => Data.
drived => derived.
| cardToPinnedCopy: CardToPinnedCard; | ||
| // A map of card ids that previously pinned by the user. | ||
| cardToPinnedCopyCache: CardToPinnedCard; | ||
| pinnedCardToOriginal: PinnedCardToCard; | ||
| cardStateMap: CardStateMap; |
There was a problem hiding this comment.
cardStateMap has both data-related (dataMinMax) and ui-related states (everything else).
Might be worth separating it out into a third category here and then similarly organizing it to clearly separate data-related and ui-related states.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-arrange metrics state order to make it clear those states might affect what aspect.