Skip to content
This repository was archived by the owner on Aug 15, 2019. It is now read-only.

change the regex check for git origin #1058

Merged
merged 1 commit into from
May 28, 2018
Merged

change the regex check for git origin #1058

merged 1 commit into from
May 28, 2018

Conversation

pyu10055
Copy link
Collaborator

@pyu10055 pyu10055 commented May 25, 2018 •
edited by dsmilkov
Loading

This change is Reviewable

@pyu10055 pyu10055 requested a review from dsmilkov May 25, 2018 18:34
@dsmilkov
Copy link
Contributor

:lgtm_strong:

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@dsmilkov dsmilkov merged commit ed06c4b into master May 28, 2018
@dsmilkov dsmilkov deleted the relex_git_origin branch May 28, 2018 19:32
jarno-r added a commit to jarno-r/tfjs-core that referenced this pull request Jan 2, 2019
@jarno-r
Fixed division by zero in QR decomposition. Issue tensorflow#1058
19ff52c
dsmilkov pushed a commit that referenced this pull request Aug 9, 2019
@jarno-r @dsmilkov
Fixed division by zero in QR decomposition. Issue #1058 (#1473)
2ae5a8a 
tensorflow/tfjs#1058
The sign() function returns 0 on 0, which causes a division by zero in the QR decomposition function qr() if there is a zero on the diagonal.

BUG
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@dsmilkov dsmilkov Awaiting requested review from dsmilkov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pyu10055 @dsmilkov