Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: add ng cli version as build arg and add new tag #77

Merged
merged 3 commits into from
Jul 20, 2022
Merged

feat: add ng cli version as build arg and add new tag #77

merged 3 commits into from
Jul 20, 2022

Conversation

xchopin
Copy link
Contributor

@xchopin xchopin commented Jul 20, 2022 •
edited
Loading

Add NG_CLI_VERSION as a build argument and create a new tag for 14.0.6

hoatle
hoatle requested changes Jul 20, 2022
View reviewed changes
Copy link
Member

@hoatle hoatle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xchopin please check my comments, thank you.

angular-cli/base/Dockerfile Outdated
@@ -9,7 +9,7 @@ ARG CI_BUILD_ID
ARG CI_BUILD_REF
ARG CI_REGISTRY_IMAGE
ARG CI_BUILD_TIME
ARG NG_CLI_VERSION=latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't change this, use it as default

@hoatle hoatle merged commit aa011bd into teracyhq:master Jul 20, 2022
@hoatle
Copy link
Member

hoatle commented Jul 20, 2022

https://hub.docker.com/layers/angular-cli/teracy/angular-cli/14.0.6/images/sha256-2f003f2e00ac0bfd6614f1e9888c3dc4af58089fdabf6ec6668b20eac9424c92?context=explore is available, thank you @xchopin.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@hoatle hoatle hoatle requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xchopin @hoatle