Feature/configure download template #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iles - configurable in placeholder element
Toflar
reviewed
Nov 16, 2023
There was a problem hiding this comment.
Hey, thanks a lot for the PR! Love it! I've noticed a few coding style issues and wondered why the CI chain is not running properly anymore. I've fixed this in main now so can I ask you to rebase? The GitHub CI chain should then tell you where the coding style does not match the rest of the project 😊
|
Hi @Toflar, I will do that. Although I am surprised that there are problems or errors. I'm actually pretty sure that I ran the cs-fixer script locally. But I'll see what the CI job says. |
…ate' into feature/configure-download-template * origin/feature/configure-download-template: Update the CI chain (#78) # Conflicts: # src/EventListener/LoadFormFieldListener.php # src/Step/FileParameterBag.php
Toflar
approved these changes
Nov 16, 2023
|
Thanks a lot for this new feature! Released as 5.1.0 😎 https://github.com/terminal42/contao-mp_forms/releases/tag/5.1.0 |
|
thx a lot for this wonderful extension and your fast reply |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small change makes the used download template configurable in the settings of the placeholder form field