Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Add support for EBS volumes #205

Merged
merged 5 commits into from
Jul 24, 2024
Merged

feat: Add support for EBS volumes #205

merged 5 commits into from
Jul 24, 2024

Conversation

rlinstorres
Copy link

@rlinstorres rlinstorres commented Jun 18, 2024

Description

This PR aims to add a feature that allows EBS volumes to be attached to the containers in the tasks.

References

Motivation and Context

Currently, the community module is allowing docker_volume_configuration, efs_volume_configuration, fsx_windows_file_server_volume_configuration and bind mounts.

Breaking Changes

N/A

Tests

  • IAM Role:
Screenshot 2024-06-19 at 5 01 15 PM Screenshot 2024-06-19 at 5 04 23 PM
  • Task definition:
Screenshot 2024-06-19 at 5 01 42 PM
  • Container definition:
Screenshot 2024-06-19 at 5 01 31 PM
  • Service
Screenshot 2024-06-19 at 5 01 56 PM

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@rlinstorres rlinstorres changed the title feat: Adding support for EBS volumes feat: Add support for EBS volumes Jun 18, 2024
@bryantbiggs bryantbiggs changed the base branch from master to wip/v6 July 24, 2024 23:33
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requires AWS provider 5.x - going into v6 branch

@bryantbiggs bryantbiggs merged commit 5f25125 into terraform-aws-modules:wip/v6 Jul 24, 2024
2 checks passed
@rlinstorres rlinstorres deleted the ebs-support branch July 25, 2024 08:27
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants