Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Add support for service connect timeout settings #212

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

salscode
Copy link

@salscode salscode commented Jul 24, 2024

Description

Adds support for timeout under service_connect_configuration.service. Within timeout, you can specify idle_timeout_seconds and per_request_timeout_seconds. Those fields are documented here. This PR replaces #210 which appears to be incomplete.

Motivation and Context

This change allows the user to modify the default idle timeout and per request timeout. The default settings are not adequate for all use cases.

Breaking Changes

None

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs bryantbiggs changed the base branch from master to wip/v6 July 24, 2024 23:11
@bryantbiggs bryantbiggs changed the base branch from wip/v6 to master July 24, 2024 23:11
@bryantbiggs bryantbiggs changed the base branch from master to wip/v6 July 24, 2024 23:17
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requires 5.37 of AWS provider so going into v6 branch

@bryantbiggs bryantbiggs merged commit 5253dc1 into terraform-aws-modules:wip/v6 Jul 24, 2024
3 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants