Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Auto Mode custom tag policy should apply to cluster role, not node role #3242

Merged

Conversation

bryantbiggs
Copy link
Member

Description

  • Auto Mode custom tag policy should apply to cluster role, not node role

Motivation and Context

Breaking Changes

  • Claiming this as a no since it never worked as intended. Yes, the policy will be destroyed and permissions removed from the node but those permissions were not being used for anything - they need to be applied to the cluster role

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs bryantbiggs merged commit a07013a into terraform-aws-modules:master Dec 14, 2024
22 checks passed
@bryantbiggs bryantbiggs deleted the fix/custom-policy branch December 14, 2024 13:28
antonbabenko pushed a commit that referenced this pull request Dec 14, 2024
## [20.31.4](v20.31.3...v20.31.4) (2024-12-14)

### Bug Fixes

* Auto Mode custom tag policy should apply to cluster role, not node role ([#3242](#3242)) ([a07013a](a07013a))
@antonbabenko
Copy link
Member

This PR is included in version 20.31.4 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants