Skip to content

feat: Support transit_encryption_mode #4

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Conversation

magreenbaum
Copy link
Member

Description

Support transit_encryption_mode for replication groups.
Added support for skip_destroy and log_group_class for aws_cloudwatch_log_group as well.

Did not add transit_encryption_mode for global replication groups since primary members cannot be replication group with transit-encryption-mode preferred.

Motivation and Context

hashicorp/terraform-provider-aws#30403

Breaking Changes

No.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bryantbiggs bryantbiggs merged commit d786a9e into terraform-aws-modules:master May 1, 2024
13 checks passed
antonbabenko pushed a commit that referenced this pull request May 1, 2024
## [1.2.0](v1.1.0...v1.2.0) (2024-05-01)

### Features

* Support `transit_encryption_mode`  ([#4](#4)) ([d786a9e](d786a9e))
@antonbabenko
Copy link
Member

This PR is included in version 1.2.0 🎉

@magreenbaum magreenbaum deleted the feat/transit_encryption_mode branch May 1, 2024 11:26
Copy link

github-actions bot commented Jun 4, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants