Make kms_master_key_id optional

[oleksii-borodai]

Sample code:

module "s3_bucket" {
  source = "terraform-aws-modules/s3-bucket/aws"

  bucket = "sample-bucket-1234567890"
  acl = "private"

  server_side_encryption_configuration = {
    rule = {
      apply_server_side_encryption_by_default = {
        sse_algorithm = "AES256"
      }
    }
  }

}

Expected outcome: Bucket created with SSE-S3 encryption.

Real outcome:

Error: Unsupported attribute

  on .terraform/modules/s3_bucket/terraform-aws-modules-terraform-aws-s3-bucket-f778720/main.tf line 190, in resource "aws_s3_bucket" "this":
 190:               kms_master_key_id = apply_server_side_encryption_by_default.value.kms_master_key_id
    |----------------
    | apply_server_side_encryption_by_default.value is object with 1 attribute "sse_algorithm"

This object does not have an attribute named "kms_master_key_id"

[oleksii-borodai]

PR #5 fixes this issue

[michael-robbins]

I'm hitting this exact issue too, @antonbabenko is there anything holding up merging this PR?

[antonbabenko]

Yes, New Year! :) Happy holidays everyone!

…

30 груд. 2019 р. о 04:35 Michael Robbins ***@***.***> пише:  I'm hitting this exact issue too, @antonbabenko is there anything holding up merging this PR? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[antonbabenko]

Thanks @aboroday for the report and fix.

v1.5.0 of this module has been just released.

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.