Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Added delete marker in replication rules #103

Closed
wants to merge 7 commits into from

Conversation

jayolmos
Copy link

@jayolmos jayolmos commented Jul 23, 2021

Description

Added "delete_marker_replication_status " in replication rules

Motivation and Context

In some cases, delete marker is mandatory in v2 replication scenarios, for example saving data that overlaps.
In v3.50 of AWS provider they added:

resource/aws_s3_bucket: Add the delete_marker_replication_status argument for V2 replication configurations (#19323)

This change only includes a new rule lookup and fallback to null. Also it implies an upgrade to 3.50 provider version.

Breaking Changes

N/A

How Has This Been Tested?

Updated in our infraestructure and changes goes from:

 + rules {
              + id       = "REDACTED"
              + priority = 10
              + status   = "Enabled"
              + destination {
                  + bucket = "arn:aws:s3:::REDACTED"
                }
              + filter {
                  + prefix = "REDACTED"
                }
            }
 - rules {
              - delete_marker_replication_status = "Enabled" -> null
              - id                               = "REDACTED" -> null
              - priority                         = 10 -> null
              - status                           = "Enabled" -> null
              - destination {
                  - bucket = "arn:aws:s3:::REDACTED- -> null
                }
              - filter {
                  - prefix = "REDACTED" -> null
                  - tags   = {} -> null
                }
            }

to no change when we add this option.

@jayolmos jayolmos changed the title Added "delete_marker_replication_status " in replication rules Added delete marker in replication rules Jul 23, 2021
@ahummel25
Copy link

@jayolmos Can the PR be fixed so this can get merged in?

@ahummel25
Copy link

Oh sorry, maybe it just needs an approval.

@antonbabenko antonbabenko changed the title Added delete marker in replication rules feat: Added delete marker in replication rules Aug 26, 2021
@antonbabenko
Copy link
Member

Finishing this one in #108 due to a lack of push permissions to the fork.

@antonbabenko
Copy link
Member

v2.9.0 has been just released.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants