fix: Always send filter map in replication config
#104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @antonbabenko, anything I can do to expedite this PR 😄? I can do more work here, if required, just unsure of next steps. |
|
Hi @smrz2001 ! All good, I will review it and release it during this week. Thank you for the fix! |
Thanks so much!! |
|
Oh apologies 😬 Thanks so much for this! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Send an empty
filtermap if no (or empty)filterwas specified inreplication_configuration.(I'm not a Terraform expert so I'm not sure if the way I've done it is the best 😅)
Motivation and Context
In the absence of at least an empty
filtermap if no filter was specified in a rule,terraform applygives the following error for multi-destination S3 replication rules. See thisterraform-provider-awsissue for additional context.Number of distinct destination bucket ARNs cannot exceed 1Breaking Changes
Does not break backwards compatibility with the current major version.
How Has This Been Tested?
examples/*projects.S3 bucket with Cross-Region Replication (CRR) enabledexample.s3_bucketto two replica buckets in the same region (one replication rule without a filter specified).Number of distinct destination bucket ARNs cannot exceed 1error with unmodified code and successful application with modifications.