Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Error when depending on other module #10

Closed
ocervell opened this issue Sep 17, 2018 · 1 comment
Closed

Error when depending on other module #10

ocervell opened this issue Sep 17, 2018 · 1 comment

Comments

@ocervell
Copy link

When we depend on another module for the project, folder, or org_id fields, we get a "count cannot be computed" error on the log sink module.

Background
@aaron-lane aaron-lane mentioned this issue Feb 15, 2019
Merged
glarizza added a commit to glarizza/terraform-google-log-export that referenced this issue Mar 20, 2019
@glarizza
Introduce separate modules for each destination
311c136 
This commit introduces a separate Terraform module for each log export
destination: bigquery, pubsub, and storage. Having separate modules per
destination allows us to reduce code complexity and will allow for
computed values in the `var.parent_resource_id` input variable (which
fixes issue terraform-google-modules#10). Output names have remained the same, but input
variables have been added or changed for clarity.
@glarizza glarizza mentioned this issue Mar 20, 2019
Merged
glarizza added a commit to glarizza/terraform-google-log-export that referenced this issue Mar 20, 2019
@glarizza
Introduce separate modules for each destination
f5d4abe 
This commit introduces a separate Terraform module for each log export
destination: bigquery, pubsub, and storage. Having separate modules per
destination allows us to reduce code complexity and will allow for
computed values in the `var.parent_resource_id` input variable (which
fixes issue terraform-google-modules#10). Output names have remained the same, but input
variables have been added or changed for clarity.
glarizza added a commit to glarizza/terraform-google-log-export that referenced this issue Mar 22, 2019
@glarizza
Refactor into destination modules
bc02e44 
This commit refactors the existing Terraform module from a single module
to a log export module with submodules for each export destination:
bigquery, pubsub, and storage. Having separate modules per destination
allows us to reduce code complexity and will allow for computed values
in the `var.parent_resource_id` input variable (which fixes issue terraform-google-modules#10).
Outputs have changed so that each module has its own dedicated output
variables (instead of maps according to export/destination), and
variables have been named so that outputs from one module designed to be
fed to the other module have similar names.  Examples have been provided
for each destination and parent resource type pairing, so there are now
12 examples demonstrating how to configure every destination and log
sink level.
glarizza added a commit to glarizza/terraform-google-log-export that referenced this issue Mar 25, 2019
@glarizza
Refactor into destination modules
f3ab475 
This commit refactors the existing Terraform module from a single module
to a log export module with submodules for each export destination:
bigquery, pubsub, and storage. Having separate modules per destination
allows us to reduce code complexity and will allow for computed values
in the `var.parent_resource_id` input variable (which fixes issue terraform-google-modules#10).
Outputs have changed so that each module has its own dedicated output
variables (instead of maps according to export/destination), and
variables have been named so that outputs from one module designed to be
fed to the other module have similar names.  Examples have been provided
for each destination and parent resource type pairing, so there are now
12 examples demonstrating how to configure every destination and log
sink level.
glarizza added a commit to glarizza/terraform-google-log-export that referenced this issue Mar 27, 2019
@glarizza
Refactor into destination modules
6dec8df 
This commit refactors the existing Terraform module from a single module
to a log export module with submodules for each export destination:
bigquery, pubsub, and storage. Having separate modules per destination
allows us to reduce code complexity and will allow for computed values
in the `var.parent_resource_id` input variable (which fixes issue terraform-google-modules#10).
Outputs have changed so that each module has its own dedicated output
variables (instead of maps according to export/destination), and
variables have been named so that outputs from one module designed to be
fed to the other module have similar names.  Examples have been provided
for each destination and parent resource type pairing, so there are now
12 examples demonstrating how to configure every destination and log
sink level.
glarizza added a commit to glarizza/terraform-google-log-export that referenced this issue Mar 27, 2019
@glarizza
Introduce kitchen-terraform tests
e1b6b69 
This commit includes all changes needed to implement kitchen-terraform
tests for the log-exports module. Tests are structured exactly the same
as examples: folders for each of the destinations, and subfolders for
each log sink level that's possible for each destination (with
billing_account as an exception - more on that later). Each test fixture
functions independently and relies upon environment variables that are
set within `test/ci_integration.sh` (environment variables for the SA
key json, project ID, and the parent resource
project/folder/org/billing_account). Like all the other CFT modules,
tests are invoked based on make targets from `Makefile`, and there are
dedicated targets for testing from the CFT Docker container as well as
directly from your laptop/machine.

A test fixture called `computed_values` has also been provided to
specifically test issue terraform-google-modules#10 of the log-export module. This test spins up
a project on the fly and passes that computed project ID to the
log-export module to ensure that the module can handle computed values.

Tests for the billing account level log sinks are not provided within this
commit and will be provided in a later commit/PR.
glarizza added a commit to glarizza/terraform-google-log-export that referenced this issue Mar 27, 2019
@glarizza
Introduce kitchen-terraform tests
002e61a 
This commit includes all changes needed to implement kitchen-terraform
tests for the log-exports module. Tests are structured exactly the same
as examples: folders for each of the destinations, and subfolders for
each log sink level that's possible for each destination (with
billing_account as an exception - more on that later). Each test fixture
functions independently and relies upon environment variables that are
set within `test/ci_integration.sh` (environment variables for the SA
key json, project ID, and the parent resource
project/folder/org/billing_account). Like all the other CFT modules,
tests are invoked based on make targets from `Makefile`, and there are
dedicated targets for testing from the CFT Docker container as well as
directly from your laptop/machine.

A test fixture called `computed_values` has also been provided to
specifically test issue terraform-google-modules#10 of the log-export module. This test spins up
a project on the fly and passes that computed project ID to the
log-export module to ensure that the module can handle computed values.

Tests for the billing account level log sinks are not provided within this
commit and will be provided in a later commit/PR.
glarizza added a commit to glarizza/terraform-google-log-export that referenced this issue Apr 3, 2019
@glarizza
Introduce kitchen-terraform tests
e585ff0 
This commit includes all changes needed to implement kitchen-terraform
tests for the log-exports module. Tests are structured exactly the same
as examples: folders for each of the destinations, and subfolders for
each log sink level that's possible for each destination (with
billing_account as an exception - more on that later). Each test fixture
functions independently and relies upon environment variables that are
set within `test/ci_integration.sh` (environment variables for the SA
key json, project ID, and the parent resource
project/folder/org/billing_account). Like all the other CFT modules,
tests are invoked based on make targets from `Makefile`, and there are
dedicated targets for testing from the CFT Docker container as well as
directly from your laptop/machine.

A test fixture called `computed_values` has also been provided to
specifically test issue terraform-google-modules#10 of the log-export module. This test spins up
a project on the fly and passes that computed project ID to the
log-export module to ensure that the module can handle computed values.

Tests for the billing account level log sinks are not provided within this
commit and will be provided in a later commit/PR.
glarizza added a commit to glarizza/terraform-google-log-export that referenced this issue Apr 3, 2019
@glarizza
Introduce kitchen-terraform tests
abf528d 
This commit includes all changes needed to implement kitchen-terraform
tests for the log-exports module. Tests are structured exactly the same
as examples: folders for each of the destinations, and subfolders for
each log sink level that's possible for each destination (with
billing_account as an exception - more on that later). Each test fixture
functions independently and relies upon environment variables that are
set within `test/ci_integration.sh` (environment variables for the SA
key json, project ID, and the parent resource
project/folder/org/billing_account). Like all the other CFT modules,
tests are invoked based on make targets from `Makefile`, and there are
dedicated targets for testing from the CFT Docker container as well as
directly from your laptop/machine.

A test fixture called `computed_values` has also been provided to
specifically test issue terraform-google-modules#10 of the log-export module. This test spins up
a project on the fly and passes that computed project ID to the
log-export module to ensure that the module can handle computed values.

Tests for the billing account level log sinks are not provided within this
commit and will be provided in a later commit/PR.
glarizza added a commit to glarizza/terraform-google-log-export that referenced this issue Apr 3, 2019
@glarizza
Introduce kitchen-terraform tests
a236620 
This commit includes all changes needed to implement kitchen-terraform
tests for the log-exports module. Tests are structured exactly the same
as examples: folders for each of the destinations, and subfolders for
each log sink level that's possible for each destination (with
billing_account as an exception - more on that later). Each test fixture
functions independently and relies upon environment variables that are
set within `test/ci_integration.sh` (environment variables for the SA
key json, project ID, and the parent resource
project/folder/org/billing_account). Like all the other CFT modules,
tests are invoked based on make targets from `Makefile`, and there are
dedicated targets for testing from the CFT Docker container as well as
directly from your laptop/machine.

A test fixture called `computed_values` has also been provided to
specifically test issue terraform-google-modules#10 of the log-export module. This test spins up
a project on the fly and passes that computed project ID to the
log-export module to ensure that the module can handle computed values.

Tests for the billing account level log sinks are not provided within this
commit and will be provided in a later commit/PR.
glarizza added a commit to glarizza/terraform-google-log-export that referenced this issue Apr 3, 2019
@glarizza
Introduce kitchen-terraform tests
100d3ad 
This commit includes all changes needed to implement kitchen-terraform
tests for the log-exports module. Tests are structured exactly the same
as examples: folders for each of the destinations, and subfolders for
each log sink level that's possible for each destination (with
billing_account as an exception - more on that later). Each test fixture
functions independently and relies upon environment variables that are
set within `test/ci_integration.sh` (environment variables for the SA
key json, project ID, and the parent resource
project/folder/org/billing_account). Like all the other CFT modules,
tests are invoked based on make targets from `Makefile`, and there are
dedicated targets for testing from the CFT Docker container as well as
directly from your laptop/machine.

A test fixture called `computed_values` has also been provided to
specifically test issue terraform-google-modules#10 of the log-export module. This test spins up
a project on the fly and passes that computed project ID to the
log-export module to ensure that the module can handle computed values.

Tests for the billing account level log sinks are not provided within this
commit and will be provided in a later commit/PR.
glarizza added a commit to glarizza/terraform-google-log-export that referenced this issue Apr 3, 2019
@glarizza
Introduce kitchen-terraform tests
95724e5 
This commit includes all changes needed to implement kitchen-terraform
tests for the log-exports module. Tests are structured exactly the same
as examples: folders for each of the destinations, and subfolders for
each log sink level that's possible for each destination (with
billing_account as an exception - more on that later). Each test fixture
functions independently and relies upon environment variables that are
set within `test/ci_integration.sh` (environment variables for the SA
key json, project ID, and the parent resource
project/folder/org/billing_account). Like all the other CFT modules,
tests are invoked based on make targets from `Makefile`, and there are
dedicated targets for testing from the CFT Docker container as well as
directly from your laptop/machine.

A test fixture called `computed_values` has also been provided to
specifically test issue terraform-google-modules#10 of the log-export module. This test spins up
a project on the fly and passes that computed project ID to the
log-export module to ensure that the module can handle computed values.

Tests for the billing account level log sinks are not provided within this
commit and will be provided in a later commit/PR.
glarizza added a commit to glarizza/terraform-google-log-export that referenced this issue Apr 4, 2019
@glarizza
Introduce kitchen-terraform tests
8a6155a 
This commit includes all changes needed to implement kitchen-terraform
tests for the log-exports module. Tests are structured exactly the same
as examples: folders for each of the destinations, and subfolders for
each log sink level that's possible for each destination (with
billing_account as an exception - more on that later). Each test fixture
functions independently and relies upon environment variables that are
set within `test/ci_integration.sh` (environment variables for the SA
key json, project ID, and the parent resource
project/folder/org/billing_account). Like all the other CFT modules,
tests are invoked based on make targets from `Makefile`, and there are
dedicated targets for testing from the CFT Docker container as well as
directly from your laptop/machine.

A test fixture called `computed_values` has also been provided to
specifically test issue terraform-google-modules#10 of the log-export module. This test spins up
a project on the fly and passes that computed project ID to the
log-export module to ensure that the module can handle computed values.

Tests for the billing account level log sinks are not provided within this
commit and will be provided in a later commit/PR.
glarizza added a commit to glarizza/terraform-google-log-export that referenced this issue Apr 4, 2019
@glarizza
Introduce kitchen-terraform tests
728de9b 
This commit includes all changes needed to implement kitchen-terraform
tests for the log-exports module. Tests are structured exactly the same
as examples: folders for each of the destinations, and subfolders for
each log sink level that's possible for each destination (with
billing_account as an exception - more on that later). Each test fixture
functions independently and relies upon environment variables that are
set within `test/ci_integration.sh` (environment variables for the SA
key json, project ID, and the parent resource
project/folder/org/billing_account). Like all the other CFT modules,
tests are invoked based on make targets from `Makefile`, and there are
dedicated targets for testing from the CFT Docker container as well as
directly from your laptop/machine.

A test fixture called `computed_values` has also been provided to
specifically test issue terraform-google-modules#10 of the log-export module. This test spins up
a project on the fly and passes that computed project ID to the
log-export module to ensure that the module can handle computed values.

Tests for the billing account level log sinks are not provided within this
commit and will be provided in a later commit/PR.
glarizza added a commit to glarizza/terraform-google-log-export that referenced this issue Apr 4, 2019
@glarizza
Introduce kitchen-terraform tests
4a4be6d 
This commit includes all changes needed to implement kitchen-terraform
tests for the log-exports module. Tests are structured exactly the same
as examples: folders for each of the destinations, and subfolders for
each log sink level that's possible for each destination (with
billing_account as an exception - more on that later). Each test fixture
functions independently and relies upon environment variables that are
set within `test/ci_integration.sh` (environment variables for the SA
key json, project ID, and the parent resource
project/folder/org/billing_account). Like all the other CFT modules,
tests are invoked based on make targets from `Makefile`, and there are
dedicated targets for testing from the CFT Docker container as well as
directly from your laptop/machine.

A test fixture called `computed_values` has also been provided to
specifically test issue terraform-google-modules#10 of the log-export module. This test spins up
a project on the fly and passes that computed project ID to the
log-export module to ensure that the module can handle computed values.

Tests for the billing account level log sinks are not provided within this
commit and will be provided in a later commit/PR.
glarizza added a commit to glarizza/terraform-google-log-export that referenced this issue Apr 4, 2019
@glarizza
Introduce kitchen-terraform tests
0223cd3 
This commit includes all changes needed to implement kitchen-terraform
tests for the log-exports module. Tests are structured exactly the same
as examples: folders for each of the destinations, and subfolders for
each log sink level that's possible for each destination (with
billing_account as an exception - more on that later). Each test fixture
functions independently and relies upon environment variables that are
set within `test/ci_integration.sh` (environment variables for the SA
key json, project ID, and the parent resource
project/folder/org/billing_account). Like all the other CFT modules,
tests are invoked based on make targets from `Makefile`, and there are
dedicated targets for testing from the CFT Docker container as well as
directly from your laptop/machine.

A test fixture called `computed_values` has also been provided to
specifically test issue terraform-google-modules#10 of the log-export module. This test spins up
a project on the fly and passes that computed project ID to the
log-export module to ensure that the module can handle computed values.

Tests for the billing account level log sinks are not provided within this
commit and will be provided in a later commit/PR.
glarizza added a commit to glarizza/terraform-google-log-export that referenced this issue Apr 4, 2019
@glarizza
Introduce kitchen-terraform tests
b2f413e 
This commit includes all changes needed to implement kitchen-terraform
tests for the log-exports module. Tests are structured exactly the same
as examples: folders for each of the destinations, and subfolders for
each log sink level that's possible for each destination (with
billing_account as an exception - more on that later). Each test fixture
functions independently and relies upon environment variables that are
set within `test/ci_integration.sh` (environment variables for the SA
key json, project ID, and the parent resource
project/folder/org/billing_account). Like all the other CFT modules,
tests are invoked based on make targets from `Makefile`, and there are
dedicated targets for testing from the CFT Docker container as well as
directly from your laptop/machine.

A test fixture called `computed_values` has also been provided to
specifically test issue terraform-google-modules#10 of the log-export module. This test spins up
a project on the fly and passes that computed project ID to the
log-export module to ensure that the module can handle computed values.

Tests for the billing account level log sinks are not provided within this
commit and will be provided in a later commit/PR.
glarizza added a commit to glarizza/terraform-google-log-export that referenced this issue Apr 5, 2019
@glarizza
Introduce kitchen-terraform tests
00830aa 
This commit includes all changes needed to implement kitchen-terraform
tests for the log-exports module. Tests are structured exactly the same
as examples: folders for each of the destinations, and subfolders for
each log sink level that's possible for each destination (with
billing_account as an exception - more on that later). Each test fixture
functions independently and relies upon environment variables that are
set within `test/ci_integration.sh` (environment variables for the SA
key json, project ID, and the parent resource
project/folder/org/billing_account). Like all the other CFT modules,
tests are invoked based on make targets from `Makefile`, and there are
dedicated targets for testing from the CFT Docker container as well as
directly from your laptop/machine.

A test fixture called `computed_values` has also been provided to
specifically test issue terraform-google-modules#10 of the log-export module. This test spins up
a project on the fly and passes that computed project ID to the
log-export module to ensure that the module can handle computed values.

Tests for the billing account level log sinks are not provided within this
commit and will be provided in a later commit/PR.
@aaron-lane
Copy link
Contributor

Fixed by #15.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ocervell @aaron-lane