Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Convert force_destroy to a var in storage destination #50

Closed
umairidris opened this issue Feb 19, 2020 · 0 comments · Fixed by #64
Closed

Convert force_destroy to a var in storage destination #50

umairidris opened this issue Feb 19, 2020 · 0 comments · Fixed by #64

Comments

@umairidris
Copy link
Contributor

terraform-google-log-export/modules/storage/main.tf

Line 39 in 702f411

force_destroy = true
can be a dangerous default.

Usually storage destination is used for longer term logging exports for compliance and auditing purposes, so having it accidentally due to a bad plan can be undesirable.

Suggest converting to a var and defaulting to false.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@umairidris