Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[WIP] Migrate bigquery and storage destination to modules #52

Closed
wants to merge 2 commits into from
Closed

Conversation

umairidris
Copy link
Contributor

@morgante an initial look to address #49 (comment).

Few comments currently:

  • Left pubsub as the current pubsub module is need of a few changes of its own first including switching to for_each from count and supporting IAM.
  • Few fields are missing in the storage/bigquery modules, will add them there first.
  • This will obviously require a new major release and migration script to migrate to the modules.
  • Also using this PR to improve some defaults and fix Convert force_destroy to a var in storage destination #50 for storage destination.

If you can give me an initial signal I can continue working on the steps above.

@umairidris umairidris requested a review from morgante March 4, 2020 18:03
@morgante
Copy link
Contributor

@umairidris Are you still working on this?

@umairidris
Copy link
Contributor Author

I have not worked on this beyond what's in this PR and will likely not have bandwidth to continue this in the near future as I am no longer actively using these submodules.

@morgante morgante closed this Jun 22, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert force_destroy to a var in storage destination
2 participants