Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

tflint: Extend runner API for accessing the root provider configuration #79

Merged
merged 1 commit into from
Dec 5, 2020

Conversation

wata727
Copy link
Member

@wata727 wata727 commented Nov 29, 2020

To cut out deep checking of AWS rules into a plugin, this PR extends runner API, adds RootProvider and EvalExprOnRootCtx.

In the ruleset plugin, an RPC server is assigned to each runner (module). If the target of the inspection is the root module, the provider configuration can be accessed, but the child module cannot access the provider configuration defined in the root.

To solve this problem, make use of the extended API to always have access to the root configuration.

See also terraform-linters/tflint#986

@wata727 wata727 force-pushed the extend_runner_api_for_accessing_root_provider branch from b060de4 to 2205685 Compare December 5, 2020 14:27
@wata727 wata727 marked this pull request as ready for review December 5, 2020 14:28
@wata727 wata727 merged commit d49361e into master Dec 5, 2020
@wata727 wata727 deleted the extend_runner_api_for_accessing_root_provider branch December 5, 2020 14:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant