tflint: Allow config to be merged even with initial values #1670
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #1604
The
tflint.Config
does not have a mechanism to distinguish between undefined and initial values, and whether or not it is overwritten was determined by whether it was different from the initial value.tflint/tflint/config.go
Lines 331 to 333 in 16e0218
However, this cannot override it to the initial value, and fails to achieve requirements like #1604.
This PR adds a flag to distinguish between undefined and initial values in
tflint.Config
. Thetfllint.Config
will only be overridden if the flag is set. With this change, the following five values can be overridden to the initial values:module
force
disabled_by_default
plugin_dir
format
However, since the initial values for these values cannot be set from the CLI, the current behavior does not change.