fix: r/vsphere_file provider crash

[stoyan-hristov]

Description

• Updates resource_vsphere_file.createDirectory method to check whether the provided file path has any parent folder(s). If there are no folders to be created we return early without invoking FileManager.MakeDirectory. This fixes the “slice bounds out of range” runtime error which was crashing the provider.
• Fixes the resource_vsphere_file_test acceptance tests as they were failing due to incorrect test vmdk files.
• Adds a new TestAccResourceVSphereFile_uploadWithCreateDirectories test to cover the r/vsphere_file.create_directories configuration argument.

Testing done:

Performed terraform apply using the following configuration:

resource "vsphere_file" "iso" {
  datacenter       = data.vsphere_datacenter.datacenter.name
  datastore        = data.vsphere_datastore.nfs-tf.name
  source_file      = "${path.cwd}/ISO/test.iso"
  destination_file = "test.iso"
  create_directories = true
}

And verified that the file was uploaded correctly without any runtime errors.

Acceptance tests

• Have you added an acceptance test for the functionality being added?

Added TestAccResourceVSphereFile_uploadWithCreateDirectories

• Have you run the acceptance tests on this branch?

Output from acceptance testing

make testacc TESTARGS="-run='TestAccResourceVSphereFile'"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run='TestAccResourceVSphereFile' -timeout 240m
?   	github.com/hashicorp/terraform-provider-vsphere	[no test files]
=== RUN   TestAccResourceVSphereFile_basic
--- PASS: TestAccResourceVSphereFile_basic (62.99s)
=== RUN   TestAccResourceVSphereFile_uploadWithCreateDirectories
--- PASS: TestAccResourceVSphereFile_uploadWithCreateDirectories (91.53s)
=== RUN   TestAccResourceVSphereFile_basicUploadAndCopy
--- PASS: TestAccResourceVSphereFile_basicUploadAndCopy (73.37s)
=== RUN   TestAccResourceVSphereFile_renamePostCreation
--- PASS: TestAccResourceVSphereFile_renamePostCreation (93.87s)
=== RUN   TestAccResourceVSphereFile_uploadAndCopyAndUpdate
--- PASS: TestAccResourceVSphereFile_uploadAndCopyAndUpdate (109.50s)
PASS

Release Note

Release note for CHANGELOG:

Bug Fix:

r/vsphere_file: Fixes a provider crash by updating the createDirectory method to check if the provided file path has any parent folder(s). If no folders need to be created FileManager.MakeDirectory is not invoked.

References

Closes #1779

[tenthirtyam]

Thank you, @stoyan-hristov.

Reviewed, successfully tested, and approved. 🚀

@appilon - contingent on your review of the update and additonal acceptance test.

[appilon]

LGTM

[github-actions]

This functionality has been released in v2.4.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.