Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: git worktree was not supported #813

Merged
merged 3 commits into from
Jan 23, 2023
Merged

fix: git worktree was not supported #813

merged 3 commits into from
Jan 23, 2023

Conversation

i4ki
Copy link
Contributor

@i4ki i4ki commented Jan 20, 2023

Reason for This Change

We were using git rev-parse --git-dir to found the .git directory and then infer the project root but this approach doesn't work with git worktree.

We are not officially announcing support for it yet as we need to better test if all Terramate features work well with worktree, but this change in one step in that direction.

Description of Changes

It was simply changed to use git rev-parse --show-toplevel.

@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Base: 71.68% // Head: 71.72% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (8f35af8) compared to base (13c43a8).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #813      +/-   ##
==========================================
+ Coverage   71.68%   71.72%   +0.03%     
==========================================
  Files          81       81              
  Lines       13043    13039       -4     
==========================================
+ Hits         9350     9352       +2     
+ Misses       3333     3327       -6     
  Partials      360      360              
Flag Coverage Δ
tests 71.72% <50.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/terramate/cli/cli.go 0.00% <0.00%> (ø)
git/git.go 75.77% <100.00%> (+0.34%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@i4ki i4ki marked this pull request as ready for review January 20, 2023 13:02
@i4ki i4ki requested a review from mariux January 20, 2023 13:31
Copy link
Contributor

@mariux mariux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@i4ki i4ki merged commit 0a21f79 into main Jan 23, 2023
@i4ki i4ki deleted the i4k-fix-worktree branch January 23, 2023 12:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants