Added option to specify which VM image to use #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from tessel/t2-vm
…instead of downloading the default one
|
Sorry for the big number of line changes, it's mostly indentation... |
…e <int> to set the number of network interfaces (all openwrt-tessel images does not have the same nb of interfaces)
|
@johnnyman727 @tcr ping ... 😉 ... I would prefer to merge this because it helps to create fast (booting) machines if you work on ideas for the firmware and you don't like to go the way over updating the hardware each time. Also in case you like to copy the result for using it by VirtualBox for experiments. @tberthe did this work and I think it is worth to merge. |
|
@Student007 I'm deferring to @tcr to review this because I'm not familiar with the code base. |
|
@johnnyman727 ok - but he should say whether he will merge or not 😄 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the option
--image <file.vdi>to specify a VM image to be used instead of downloading and using the default one. (It's usefull for self compiled VM images)