chore: Replace Docker.DotNet with the Testcontainers organization's build #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HofmeisterAn
added
the
chore
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As mentioned in the forked repository, we tried to reach out to the .NET Foundation, the maintainer, and others to offer our help in maintaining the project, addressing Docker Engine API updates, bug fixes, new features, and GitHub issues. Unfortunately, we were not able to get in touch with anyone properly. If the upstream repository becomes active again, I would be happy to replace the package again and bring the changes made in the fork back to the upstream.
This PR replaces Docker.DotNet with the build from the Testcontainers organization. The new version already includes several improvements: v3.126.0.
Why is it important?
The upstream repository appears to been inactive for quite a while now. Docker.DotNet is an important upstream dependency for Testcontainers, and we need to ensure that we can quickly provide changes to the Docker Engine API or important bug fixes.
Related issues
-