feat: Include file path in TarException: Entry closed at [...] (Docker build) #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
HofmeisterAn
deleted the
feature/improve-docker-image-build-error-message
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Checks in advance if a file is used by another process or not. SharpZipLib creates the entry, but does not write the bytes if a file is used by another process. Disposing the tar archive object throws a TarException if entries exist without bytes.
Why is it important?
The TarException does not help developers to understand the underlying issue. The PR adds the information about the file used by another process.
Related issues
WriteEntry(TarEntry, bool)writes the entry without bytes if the file is used by another process icsharpcode/SharpZipLib#819