fix: port forwarding race condition #2686
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Fix port forwarding race condition by waiting for the exposed port which was causing random test failures. Make errors and parameters more consumable while there.
stevenh
force-pushed
the
fix/port-forwarding-race
branch
from
b5fb18e to
26c4642
Compare
Yep when you wrap having multiple
With wrapping my rule is to describe the action which errored, which typically is a human readable version of the function call. |
Cool, thanks for the explanation. In that case, I think we're going to need a new PR to update the format to the one you propose. Fine for this PR, and not urgent at all. |
* main: fix(compose): remove test volumes (#2712) chore(mysql): add missing error check in example (#2707) chore: remove unused params from defaultPreCreateHook (#2714) docs: improve docs for container methods (#2713) chore(registry): disable build log (#2711) chore: remove obsolete compose version (#2710) chore: improve lifecycle errors (#2708) docs: add consistent snippets for network creation (#2703) test: add retry on system error test (#2687) Redpanda Module: Add option for arbitrary bootstrap config (#2666) feat(inbucket): expose POP3 and wait for all ports (#2690) fix(wait): data race in test (#2698) fix(milvus): racy container setup (#2693) fix(mongodb): replica test failures (#2699) test: racy port creation in port forwarding tests (#2688) fix: port forwarding race condition (#2686)
Fix port forwarding race condition by waiting for the exposed port which was causing random test failures.
Make errors and parameters more consumable while there.