Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: readd dependabot, including a way to refresh the project files for all the modules #2997

Merged
merged 26 commits into from
Mar 11, 2025

Conversation

mdelapenya
Copy link
Member

  • chore: bring back dependabot generation
  • chore: replace assert with require
  • feat: add a modulegen command to refresh the project files
  • chore: exclude compose from the mkdocs nav entries
  • fix: remove extra comma after refresh
  • chore: readd dependabot updates
  • fix: lint
  • chore: wrap errors in dependabot files
  • docs: document new types and functions
  • chore: simplify types merging generator and refresher
  • chore: include modulegen in dependabot
  • chore: check modulegen is included in the dependabot updates
  • docs: document new command
  • chore: exclude dependabot changes from the build pipeline

What does this PR do?

This PR enables dependabot for all the modules in the project so that they receive updates when needed.

It also adds the automation for creating dependabot updates for the new modules added with the code generation tool, and a new refresh command to refresh all the project files:

  • dependabot.yml
  • mkdocs.yml
  • sonar.properties
  • vscode project file

As a consequence, the unit tests for the modulegen module has been updated (simplified?) making them not affecting the current workspace: for that, the project and module files will be copied to a temp dir, and the test context will happen there, not adding dirty to the current workspace.

Finally, the dependabot file has been excluded from the automation to detect changed, so that a change on it does not include all the modules in the CI pipeline.

Why is it important?

Given the CI pipeline is now more efficient, only running the modified modules, now it's possible to handle dependabot updates not consuming all the GHA runners at a time. Instead just 4 runners will be used for testing the changes: detect + lint + testx2 + end, which is way faster than before, where the entire pipeline had to be built (~100 workers), adding flakiness.

@mdelapenya mdelapenya requested a review from a team as a code owner February 26, 2025 13:55
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Feb 26, 2025
@mdelapenya mdelapenya self-assigned this Feb 26, 2025
@mdelapenya mdelapenya requested a review from stevenh February 26, 2025 13:55
Copy link

netlify bot commented Feb 26, 2025

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 29cb0fa
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/67d0192377e81100083da5e1
😎 Deploy Preview https://deploy-preview-2997--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdelapenya
Copy link
Member Author

@mmorel-35 as contributor of the modulegen, would you like to take a look at this? 🙏

Copy link
Contributor

@mmorel-35 mmorel-35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@stevenh stevenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loving all the additional docs and general clean ups. Just a few suggestions.

@mdelapenya mdelapenya requested a review from stevenh February 27, 2025 11:52
Copy link
Contributor

@stevenh stevenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions before I continue on review.

@mdelapenya mdelapenya requested a review from stevenh February 27, 2025 17:31
* main:
  docs: refine texts on how to set the module image (testcontainers#3012)
  feat(modules): add dind module (testcontainers#3004)
  docs: correct container variable (testcontainers#3010)
Copy link
Contributor

@stevenh stevenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdelapenya mdelapenya merged commit 051ee32 into testcontainers:main Mar 11, 2025
185 checks passed
@mdelapenya mdelapenya deleted the bring-back-dependabot branch March 11, 2025 17:25
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Mar 12, 2025
* main:
  chore(deps): bump github.com/opencontainers/image-spec from 1.1.0 to 1.1.1, dario.cat/mergo from 1.0.0 to 1.0.1 (testcontainers#3030)
  chore(deps): bump github/codeql-action from 3.28.0 to 3.28.11 (testcontainers#3014)
  chore(deps): bump ossf/scorecard-action from 2.4.0 to 2.4.1 (testcontainers#3013)
  chore: readd dependabot, including a way to refresh the project files for all the modules (testcontainers#2997)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants