-
-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore: readd dependabot, including a way to refresh the project files for all the modules #2997
chore: readd dependabot, including a way to refresh the project files for all the modules #2997
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@mmorel-35 as contributor of the modulegen, would you like to take a look at this? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ntry per Go module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loving all the additional docs and general clean ups. Just a few suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions before I continue on review.
* main: docs: refine texts on how to set the module image (testcontainers#3012) feat(modules): add dind module (testcontainers#3004) docs: correct container variable (testcontainers#3010)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* main: chore(deps): bump github.com/opencontainers/image-spec from 1.1.0 to 1.1.1, dario.cat/mergo from 1.0.0 to 1.0.1 (testcontainers#3030) chore(deps): bump github/codeql-action from 3.28.0 to 3.28.11 (testcontainers#3014) chore(deps): bump ossf/scorecard-action from 2.4.0 to 2.4.1 (testcontainers#3013) chore: readd dependabot, including a way to refresh the project files for all the modules (testcontainers#2997)
What does this PR do?
This PR enables dependabot for all the modules in the project so that they receive updates when needed.
It also adds the automation for creating dependabot updates for the new modules added with the code generation tool, and a new
refresh
command to refresh all the project files:As a consequence, the unit tests for the modulegen module has been updated (simplified?) making them not affecting the current workspace: for that, the project and module files will be copied to a temp dir, and the test context will happen there, not adding dirty to the current workspace.
Finally, the dependabot file has been excluded from the automation to detect changed, so that a change on it does not include all the modules in the CI pipeline.
Why is it important?
Given the CI pipeline is now more efficient, only running the modified modules, now it's possible to handle dependabot updates not consuming all the GHA runners at a time. Instead just 4 runners will be used for testing the changes: detect + lint + testx2 + end, which is way faster than before, where the entire pipeline had to be built (~100 workers), adding flakiness.