Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove unused JEE deps #2505

Merged
merged 2 commits into from
Apr 12, 2020
Merged

Remove unused JEE deps #2505

merged 2 commits into from
Apr 12, 2020

Conversation

dajudge
Copy link
Member

@dajudge dajudge commented Apr 1, 2020

Two compile dependencies referencing JEE artifacts don't seem to be required for compilation. This PR removes them from the build.

Closes #2091

Co-Authored-By: Sergei Egorov <bsideup@gmail.com>
@bsideup bsideup added this to the next milestone Apr 1, 2020
@bsideup bsideup added the dependencies Pull requests that update a dependency file label Apr 1, 2020
@rnorth
Copy link
Member

rnorth commented Apr 4, 2020

If we don't need these then presumably #2091 is not needed? That seems like it would be a good outcome to me...

@bsideup bsideup merged commit ee05f4a into testcontainers:master Apr 12, 2020
quincy pushed a commit to quincy/testcontainers-java that referenced this pull request May 28, 2020
Two compile dependencies referencing JEE artifacts don't seem to be required for compilation. This PR removes them from the build.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants