Skip to content

Remove unused charset constant in GenericContainer #8304

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2024
Merged

Remove unused charset constant in GenericContainer #8304

merged 1 commit into from
Feb 12, 2024

Conversation

dreis2211
Copy link
Contributor

@dreis2211 dreis2211 commented Feb 12, 2024 •
edited
Loading

Hi,

originally I stumbled upon this because I wanted to change Charset.forName("UTF-8") to StandardCharsets.UTF_8 but it seems the constant is not used at all anymore.

Cheers,
Christoph

@dreis2211 dreis2211 requested a review from a team as a code owner February 12, 2024 19:19
@eddumelendez eddumelendez added this to the next milestone Feb 12, 2024
@eddumelendez eddumelendez merged commit a69750c into testcontainers:main Feb 12, 2024
@eddumelendez
Copy link
Member

Thanks for your contribution, @dreis2211 !

fokion pushed a commit to fokion/testcontainers-java that referenced this pull request Jan 18, 2025
@dreis2211 @fokion
Remove unused charset constant in GenericContainer (testcontainers#8304)
a13e8a1
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@eddumelendez eddumelendez eddumelendez approved these changes

Assignees
No one assigned
Labels
type/housekeeping
Projects
None yet
Milestone
1.19.6
Development

Successfully merging this pull request may close these issues.
2 participants
@dreis2211 @eddumelendez