Allow copy specific files to docker compose #8848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wimdeblauwe
force-pushed
the
feature/gh-8847
branch
from
b1d39fd to
45a2203
Compare
|
Hi @wimdeblauwe, thanks for your contribution! I think this is a nice improvement. Do you mind adding some docs here and tests as well, please? |
…containers#8847) This commit adds support for a `withFileCopyInclusions` method on `ComposeContainer` and `DockerComposeContainer`. It allows to specify what files or directories should be copied, instead of just copying all files. If not used, the current behaviour is preserved.
wimdeblauwe
force-pushed
the
feature/gh-8847
branch
from
45a2203 to
9ba8a33
Compare
|
@eddumelendez Thanks for considering my PR! I have added documentation and tests now. |
|
great! thanks! Running |
wimdeblauwe
force-pushed
the
feature/gh-8847
branch
from
1e89afd to
fa1cacd
Compare
|
@eddumelendez build is ok now. |
eddumelendez
changed the title
|
Thanks for your contribution, @wimdeblauwe ! I made some changes and rename the method. |
fokion
pushed a commit
to fokion/testcontainers-java
that referenced
this pull request
Jan 18, 2025
This commit adds support for a `withCopyFilesInContainer` method on `ComposeContainer` and `DockerComposeContainer`. It allows to specify what files or directories should be copied, instead of just copying all files. If not used, the current behavior is preserved. Fixes testcontainers#8847 --------- Co-authored-by: Eddú Meléndez <eddu.melendez@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for a
withFileCopyInclusionsmethod onComposeContainerandDockerComposeContainer. It allows to specify what files or directories should be copied, instead of just copying all files. If not used, the current behaviour is preserved.