Skip to content

Migrate to DockerCompose V2 #358

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
Tracked by #405
balint-backmaker opened this issue May 24, 2023 · 3 comments
Closed
Tracked by #405

Migrate to DockerCompose V2 #358

balint-backmaker opened this issue May 24, 2023 · 3 comments

Comments

@balint-backmaker
Copy link
Contributor

balint-backmaker commented May 24, 2023

Motivation

  • Docker Compose v2 offers more features that we can make use of and create a better developer experience.
  • Docker Compose v1 will no longer be receiving updates after June 2023 so we should deprecate the usage of it

Notable features

The challenges

  • dual support of v1 and v2:
    • legacy support means tougher feature parity and more testing needed for something that is in fact deprecated
    • I'd like to drop it, but this means compose contains a breaking change
    • so what is the next major release for testcontainers-python ? 🙂
  • docker compose v2 is not a python package (it's written in golang and I'm not sure I'm up for making a binding for this)
    • so need to agree on a sensible way to check this on instantiation of a DockerCompose object.
    • Not hard, just needs some reviews and is a breaking change

Final thoughts

I'm happy to pick this up, in fact I have a local copy with a bunch of goodies, just need some community support in how to introduce this change.

Also since this is likely a breaking change for the compose plugin, your thoughts on how to version this would be very welcome @tillahoffmann 🙏

@antoine-de
Copy link

This would be a really nice feature now that Docker compose v1 is EOL 🙏

@alexanderankin
Copy link
Member

ContainerisedDockerCompose
here is how testcontainers-java does it

e.g. https://github.com/testcontainers/testcontainers-java/blob/main/core/src/main/java/org/testcontainers/containers/DockerCompose.java

@alexanderankin
Copy link
Member

merged in #426 , released in #330

alexanderankin added a commit that referenced this issue May 25, 2024
…0.0.0.0" - adjust to 127.0.0.1 (#457)

#358 

not sure if this is the right solution
mbenabda pushed a commit to mbenabda/testcontainers-python that referenced this issue May 25, 2024
…0.0.0.0" - adjust to 127.0.0.1 (testcontainers#457)

testcontainers#358 

not sure if this is the right solution
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

3 participants