Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add ResourceCleaner for stop containers after exit (#104) #208

Merged
merged 4 commits into from
Jan 5, 2023

Conversation

mrk-andreev
Copy link

I suggest to stop all containers after application stop. I used atexit like JVMHookResourceReaper in testcontainers-java.

@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2022

Codecov Report

Merging #208 (3e0175b) into master (c5b7b1c) will decrease coverage by 0.40%.
The diff coverage is 61.53%.

❗ Current head 3e0175b differs from pull request most recent head d32e089. Consider uploading reports for the commit d32e089 to get more accurate results

@@            Coverage Diff             @@
##           master     #208      +/-   ##
==========================================
- Coverage   87.12%   86.72%   -0.41%     
==========================================
  Files          30       30              
  Lines         839      851      +12     
  Branches       58       58              
==========================================
+ Hits          731      738       +7     
- Misses         78       83       +5     
  Partials       30       30              
Impacted Files Coverage Δ
testcontainers/core/docker_client.py 56.36% <61.53%> (+0.54%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gaby
Copy link

gaby commented Aug 29, 2022

@mrk-andreev Any updates on this?

@tillahoffmann tillahoffmann merged commit 8ab1024 into testcontainers:master Jan 5, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants