fix(core): multiple container start invocations with custom labels #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When invoking .start() multiple times on the same DockerContainer instance,
the call fails with "ValueError: The org.testcontainers namespace is reserved for internal use" error.
Example code:
```
from testcontainers.core.container import DockerContainer
container = DockerContainer("alpine:latest").with_kwargs(labels={})
container.start()
container.stop()
container.start()
```
The fix is to update labels for the container in a copy of the user-provided dictionary,
so that:
* the code doesn't mutate user structures
* avoid side effects, allowing for multiple .start() invocations
neykov
force-pushed
the
no-labels-reuse
branch
from
31f3f68 to
5045e04
Compare
alexanderankin
changed the title
alexanderankin
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #769 +/- ##
=======================================
Coverage ? 85.32%
=======================================
Files ? 12
Lines ? 668
Branches ? 105
=======================================
Hits ? 570
Misses ? 75
Partials ? 23 ☔ View full report in Codecov by Sentry. |
alexanderankin
approved these changes
Feb 11, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When invoking
.start()multiple times on the sameDockerContainerinstance, the call fails withValueError: The org.testcontainers namespace is reserved for internal useerror.Example code:
The fix is to update labels for the container in a copy of the user-provided dictionary, so that: