refactor!: changed KAFKA_PORT to a ContainerPort
#185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CommanderStorm
force-pushed
the
refactored-kafka-ports
branch
from
234b70f to
71d2a55
Compare
CommanderStorm
changed the title
KAFKA_PORT/ZOOKEEPER_PORT into a ContainerPortKAFKA_PORT to a ContainerPort
CommanderStorm
force-pushed
the
refactored-kafka-ports
branch
2 times, most recently
from
241611c to
2533ac3
Compare
…ort` before publishing
…nvention of being a `ContainerPort` This reverts commit 1c6ba59.
CommanderStorm
force-pushed
the
refactored-kafka-ports
branch
from
2533ac3 to
55e58bd
Compare
DDtKey
approved these changes
Aug 21, 2024
DDtKey
reviewed
Aug 21, 2024
DDtKey
reviewed
Aug 21, 2024
CommanderStorm
commented
Aug 21, 2024
Merged
DDtKey
pushed a commit
that referenced
this pull request
Aug 31, 2024
## 🤖 New release * `testcontainers-modules`: 0.9.0 -> 0.10.0 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.10.0] - 2024-08-31 ### Bug Fixes - Doc-test failures ([#186](#186)) ### Documentation - Added docs for Apache ZooKeeper ([#184](#184)) - Documented all ports which containers at least expose ([#183](#183)) - Enable `rustfmt` for doc comments ([#187](#187)) - Fixed rustfmt violation in the `openldap` module ([#189](#189)) - Fixed a bit of missing docs in the openldap module ([#191](#191)) - Complete the documentation for the meilisearch module ([#192](#192)) - Complete the `*_PORT` documentation ([#195](#195)) - Add `pub mod` docs ([#193](#193)) - Documents the neo4j plugins ([#194](#194)) ### Features - Added an `OpenLDAP` testcontainer module ([#180](#180)) - Add support for `apache\kafka` docker image ([#178](#178)) - [**breaking**] Update `testcontainers` to 0.22.0 ([#203](#203)) ### Miscellaneous Tasks - Changed from `actions-rs` to a more maintained CI alternative ([#188](#188)) ### Refactor - [**breaking**] Changed `KAFKA_PORT` to a `ContainerPort` ([#185](#185)) <!-- generated by git-cliff --> </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor!: made sure that
KAFKA_PORTfollow the convention of being aContainerPortThis reverts commit 1c6ba59.
It is based on #183 => if said PR is merged, the unrelated changes (included to make merge-conflicts less likely) will merge/rebase away and only the kafka changes are left.