Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(openldap): tls certs and ldif file #217

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

guenhter
Copy link
Contributor

Support the operations

with_ldif_file(...)
with_certs(...)

on the OpenLdap Container

CommanderStorm added a commit to CommanderStorm/testcontainers-rs-modules-community that referenced this pull request Sep 25, 2024
CommanderStorm added a commit to CommanderStorm/testcontainers-rs-modules-community that referenced this pull request Sep 25, 2024
CommanderStorm added a commit to CommanderStorm/testcontainers-rs-modules-community that referenced this pull request Sep 25, 2024
@guenhter guenhter force-pushed the openldap-files branch 2 times, most recently from 390b573 to 6d040ed Compare September 26, 2024 05:09
@DDtKey DDtKey changed the title Openldap files feat(openldap): tls certs and ldif file Sep 26, 2024
@DDtKey
Copy link
Contributor

DDtKey commented Sep 26, 2024

Thank you for the contribution! 🚀

@guenhter
Copy link
Contributor Author

I squashed the commits to fix the "faulty" commit with '.map(|x| x)' (I honestly don't know what I was thinking there :| ) and also rebased onto the latest main

DDtKey pushed a commit that referenced this pull request Sep 26, 2024
…#182)

Resolves #164

~The implementation is a bit hacky, am open to better approaches or
other feedback ^^~

The implementation is pretty straigtforeward and similar to
#217
@DDtKey DDtKey merged commit b849e57 into testcontainers:main Sep 26, 2024
6 checks passed
@guenhter guenhter deleted the openldap-files branch September 26, 2024 14:58
@github-actions github-actions bot mentioned this pull request Sep 26, 2024
@guenhter
Copy link
Contributor Author

Thx for the fast response time. Appreciate that.

When do you think this will be available in a new release?

DDtKey pushed a commit that referenced this pull request Sep 26, 2024
## 🤖 New release
* `testcontainers-modules`: 0.11.0 -> 0.11.1 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

## [0.11.1] - 2024-09-26

### Documentation

- Disallow missing docs on crate level and allow where necessary
([#222](#222))

### Features

- Implement `with_init_sql` for `Postgres`, `Mysql` and `Mariadb`
([#182](#182))
- Tls certs and ldif file
([#217](#217))

<!-- generated by git-cliff -->
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@DDtKey
Copy link
Contributor

DDtKey commented Sep 26, 2024

It's already been released as 0.11.1

@guenhter
Copy link
Contributor Author

That is awesome. Thank you so much.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants