Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Attempt to use power-assert. #18

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Attempt to use power-assert. #18

wants to merge 1 commit into from

Conversation

searls
Copy link
Member

@searls searls commented Apr 16, 2016

Not Ready to Merge

  • Blow away node_modules/ before installing for some reason ¯_(ツ)_/¯
  • wait for espower #embedded-recorder branch to release to npm

Resolves #17

@searls
Copy link
Member Author

searls commented Apr 16, 2016

Hey @twada, I attempted to apply the patch you so kindly produced here: power-assert-js/power-assert#42 (comment)

Unfortunately, I wasn't able to get it to work locally. Any ideas?

@searls
Copy link
Member Author

searls commented Apr 16, 2016

@twada - nevermind, I blew away node_modules and reinstalled and my tests started passing, thanks!

When might the WIP version of power-assert-js/espower#embedded-recorder get merged in and released to npm? I want to wait until it is before merging

Thanks for your work!

Throws the same error that it has thrown:

```
not ok 3 - "modeSwitchCapturesLogs" - test #3 in `lib/log.test.js`
  ---
  message: assert._capt is not a function
  stacktrace: TypeError: assert._capt is not a function
    at [object Object].module.exports.modeSwitchCapturesLogs (lib/log.test.js:26:18)
    at /Users/justin/code/testdouble/scripty/node_modules/teenytest/lib/user-function-async-wrapper-factory.js:10:22
    at /Users/justin/code/testdouble/scripty/node_modules/teenytest/node_modules/async/lib/async.js:718:13
    at Immediate.iterate [as _onImmediate] (/Users/justin/code/testdouble/scripty/node_modules/teenytest/node_modules/async/lib/async.js:262:13)
    at processImmediate [as _immediateCallback] (timers.js:374:17)
  ...
```

My `npm version`:

```
{ scripty: '1.2.2',
  npm: '2.14.4',
  ares: '1.10.1-DEV',
  http_parser: '2.5.0',
  modules: '46',
  node: '4.1.1',
  openssl: '1.0.2d',
  uv: '1.7.4',
  v8: '4.5.103.33',
  zlib: '1.2.8' }
```
@twada
Copy link

twada commented Apr 19, 2016

@searls I'm glad to hear that my patch works 😃

When might the WIP version of power-assert-js/espower#embedded-recorder get merged in and released to npm? I want to wait until it is before merging

I'm trying to ship it in this month. Please stay tuned.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants