Skip to content

feat(no-node-access): extend no-node-access to disallow DOM event methods #1023

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 5 commits into from
Jun 9, 2025

Conversation

y-hsgw
Copy link
Member

@y-hsgw y-hsgw commented Jun 6, 2025

Checks

Changes

  • Extended the no-node-access rule to also disallow direct calls to DOM event methods like .click(), .focus(), .blur(), .select(), and .submit().

Context

#752

Copy link

codecov bot commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.30%. Comparing base (665577c) to head (4269fcb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1023      +/-   ##
==========================================
+ Coverage   96.29%   96.30%   +0.01%     
==========================================
  Files          47       47              
  Lines        2534     2542       +8     
  Branches     1047     1051       +4     
==========================================
+ Hits         2440     2448       +8     
  Misses         94       94              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Belco90 Belco90 assigned Belco90 and y-hsgw and unassigned Belco90 Jun 9, 2025
@Belco90 Belco90 self-requested a review June 9, 2025 05:13
@Belco90 Belco90 added the enhancement New feature or request label Jun 9, 2025
@y-hsgw y-hsgw requested a review from Belco90 June 9, 2025 12:10
@Belco90 Belco90 merged commit 934bc5e into testing-library:main Jun 9, 2025
31 checks passed
Copy link

github-actions bot commented Jun 9, 2025

🎉 This PR is included in version 7.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@y-hsgw y-hsgw deleted the pr/enhance-no-node-access branch June 9, 2025 12:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants