Skip to content

fix(no-node-access): stop reporting focus() usage #1028

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Jun 11, 2025

Conversation

y-hsgw
Copy link
Member

@y-hsgw y-hsgw commented Jun 11, 2025

Checks

Changes

  • remove 'focus' from EVENT_HANDLER_METHODS for consistency

Context

Fixes #1027

Copy link

codecov bot commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.30%. Comparing base (67f08f9) to head (c6c5cdb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1028   +/-   ##
=======================================
  Coverage   96.30%   96.30%           
=======================================
  Files          47       47           
  Lines        2542     2543    +1     
  Branches     1046     1051    +5     
=======================================
+ Hits         2448     2449    +1     
  Misses         94       94           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add these two things to the rule's doc?

  1. A GitHub Alert indicating why focus() is not reported
  2. A link in the Further reading section at the bottom pointing to https://testing-library.com/docs/guide-events/

@Belco90 Belco90 changed the title fix(no-node-access): no-node-access shouldn't report focus() usage fix(no-node-access): stop reporting focus() usage Jun 11, 2025
@y-hsgw
Copy link
Member Author

y-hsgw commented Jun 11, 2025

I added in c6c5cdb!📕

@y-hsgw y-hsgw requested a review from Belco90 June 11, 2025 14:19
@Belco90 Belco90 merged commit 6ed3785 into testing-library:main Jun 11, 2025
31 checks passed
Copy link

🎉 This PR is included in version 7.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@y-hsgw y-hsgw deleted the pr/fix-no-node-access branch June 11, 2025 14:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no-node-access shouldn't report focus() usage
2 participants