Skip to content

test: refactor @marko/testing-library tests #582

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
May 12, 2022

Conversation

MichaelDeBoey
Copy link
Member

@MichaelDeBoey MichaelDeBoey commented May 11, 2022

Follow-up of #572.

All rules that are included in the marko config should test that the rule is working for @marko/testing-library as well.

To do so for #572, @PrashantAshok copied over some tests and replaced the import, but didn't include tests for the following rules:

  • await-async-utils
  • no-promise-in-fire-event
  • no-render-in-setup
  • no-wait-for-snapshot
  • prefer-find-by

The way I presented in the PR, is to map over an array of the already tested framework + @marko/testing-library.
This PR is only doing that.

I'll create a separate PR to test against all testing framework that the rules support.

@MichaelDeBoey MichaelDeBoey self-assigned this May 11, 2022
timdeschryver
timdeschryver previously approved these changes May 11, 2022
@Belco90
Copy link
Member

Belco90 commented May 11, 2022

What happened with the previous review? 🤔

@timdeschryver
Copy link
Member

I think more code got refactored 😁

@MichaelDeBoey
Copy link
Member Author

All should be fine now 🙈

@PrashantAshok
Copy link
Contributor

PrashantAshok commented May 11, 2022

I think more code got refactored 😁

Exactly.

Good work @MichaelDeBoey.

@MichaelDeBoey
Copy link
Member Author

btw wonder what's up with calling out my name specifically

@PrashantAshok I just wanted to provide context & let you know about this PR, that's all 🤷‍♂️

@github-actions
Copy link

🎉 This PR is included in version 5.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants