Skip to content

Sync to @testing-library/react-hooks@3.4.1 #9

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 4 commits into from
Sep 28, 2020
Merged

Sync to @testing-library/react-hooks@3.4.1 #9

merged 4 commits into from
Sep 28, 2020

Conversation

aduth
Copy link
Contributor

@aduth aduth commented Sep 13, 2020

Closes #6
Closes #7
Closes #8

This pull request seeks to sync @testing-library/preact-hooks to be brought in line with the latest @testing-library/react-hooks (v3.4.1).

Specifically, this includes:

v3.4.1

v3.3.0

v3.2.0

  • Introduced /pure inmport as alternative to skip auto cleanup

@CarsonMcKinstry
Copy link
Collaborator

Thanks @aduth for these updates!

@CarsonMcKinstry CarsonMcKinstry merged commit e54ace6 into testing-library:master Sep 28, 2020
@aduth aduth deleted the sync-react-hooks-3-4-1 branch September 28, 2020 21:26
expect(result.current).toBe("third");
complete = true;
});
expect(complete).toBe(true);
});

test.only("should wait for arbitrary expectation to pass", async () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .only here should have been removed 😓

Suggested change
test.only("should wait for arbitrary expectation to pass", async () => {
test("should wait for arbitrary expectation to pass", async () => {

Removed in #12

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
2 participants