Skip to content

Update @types/testing-library__react-hooks dependency version #453

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Conversation

cliffzhaobupt
Copy link
Contributor

@cliffzhaobupt cliffzhaobupt commented Sep 18, 2020

What:

Update the version of dependency @types/testing-library__react-hooks

Why:

In 3.3.0, there's no type definition of waitFor, so in my project I have to use the deprecated wait instead.

How:

Run npm update @types/testing-library__react-hooks

Checklist:

  • Documentation updated
  • Tests
  • Ready to be merged
  • Added myself to contributors table

@cliffzhaobupt cliffzhaobupt changed the title chore: update @types/testing-library__react-hooks dependency version Update @types/testing-library__react-hooks dependency version Sep 18, 2020
@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #453 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #453   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          107       107           
  Branches        19        19           
=========================================
  Hits           107       107           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36ea287...625b2fb. Read the comment docs.

@mpeyper
Copy link
Member

mpeyper commented Sep 18, 2020

I wonder if we can configure @renovate-bot to keep that one up to date, even though it's not pinned, without including all the regular dependencies? I'll look into that.

Thanks 😃

@mpeyper mpeyper merged commit e519ff3 into testing-library:master Sep 18, 2020
@cliffzhaobupt cliffzhaobupt deleted the pr/update-types-dependency-version branch September 18, 2020 04:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants