Skip to content

fix: improve warning so people know they can upgrade to 16.9.0 now #431

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Aug 8, 2019

Conversation

kentcdodds
Copy link
Member

What:

improve warning so people know they can upgrade to 16.9.0 now

Why:

Closes #281

How:

Removed the src/react-dom-16.9.0-is-released.js because it's released now! Update the tests to not mock that module because it's no longer needed.

Checklist:

  • Documentation added to the
    docs site N/A
  • Tests
  • Typescript definitions updated N/A
  • Ready to be merged

@codecov
Copy link

codecov bot commented Aug 8, 2019

Codecov Report

Merging #431 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #431   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      3    -1     
  Lines          99     91    -8     
  Branches       15     12    -3     
=====================================
- Hits           99     91    -8
Impacted Files Coverage Δ
src/act-compat.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98b9605...d01dfa0. Read the comment docs.

@kentcdodds kentcdodds merged commit c026650 into master Aug 8, 2019
@kentcdodds kentcdodds deleted the pr/16.9.0 branch August 8, 2019 22:54
@kentcdodds
Copy link
Member Author

🎉 This PR is included in version 8.0.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[5.5.0] Getting warning about "act" anyway
1 participant