Skip to content

Copy in waitForElement docs #73

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

alexkrolick
Copy link
Collaborator

What:

Why:

How:

Checklist:

  • Documentation
  • Tests
  • Ready to be merged
  • Added myself to contributors table

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I don't think we need more than just an example and a link to the docs in dom-testing-library.

@alexkrolick
Copy link
Collaborator Author

Changed it to just type signature + link

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just add a simple usage example. 90% of people will understand how to use it from that, the other 10% can look at the dom-testing-library docs.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coolio! Thanks!

@kentcdodds kentcdodds merged commit cb221de into testing-library:master May 4, 2018
@alexkrolick alexkrolick deleted the chore/waitforelement-docs branch May 4, 2018 19:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants