Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

Added OSGi metadata using bnd-maven-plugin #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kriegfrj
Copy link

@kriegfrj kriegfrj commented Jul 6, 2020

This makes TestNG usable with JUnit-Platform in an OSGi environment.

Signed-off-by: kriegfrj <fr.jkrieg@greekwelfaresa.org.au>
Copy link
Collaborator

@sormuras sormuras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, the CI build is green.

I did not check the resulting OSGi metadata produced by bnd, though.

@sormuras
Copy link
Collaborator

There two new warnings in the build log reading:

[WARNING] Cannot consider developer in line '35' of file '/home/travis/build/testng-team/testng-junit5/pom.xml' for bundle header 'Bundle-Developers' as it does not contain the mandatory id.
[WARNING] Cannot consider developer in line '38' of file '/home/travis/build/testng-team/testng-junit5/pom.xml' for bundle header 'Bundle-Developers' as it does not contain the mandatory id.

@juherr
Copy link
Member

juherr commented Jul 10, 2020

Ids to add: cbeust + krmahadevan

@kriegfrj
Copy link
Author

I did not check the resulting OSGi metadata produced by bnd, though.

I know that there are some problems with it (eg, missing version numbers on package imports). I just put something together quickly in response to bndtools/bnd#4213.

What is the long term plan for this project?

@juherr
Copy link
Member

juherr commented Jul 10, 2020

What is the long term plan for this project?

It will depend on its usage: a lot of things are missing in TestNG-core for a good integration and there is no plan to add them quickly.
IMO, testng-junit5 is currently more a POC but can already be used in some simple cases.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants