-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
refactor: Leaderboard files from java to kotlin #452
Open
PruthiviRaj27
wants to merge
4
commits into
master
Choose a base branch
from
refactorleaderboard
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karthik-0
reviewed
Nov 14, 2022
Comment on lines
53
to
79
carouselView = view.findViewById<LinearLayout>(R.id.fragment_carousel) as LinearLayout | ||
viewPager = view.findViewById<ViewPager>(R.id.viewpager) as ViewPager | ||
tabLayout = view.findViewById<TabLayout>(R.id.tab_layout) as TabLayout | ||
emptyView = view.findViewById<LinearLayout>(R.id.empty_container) as LinearLayout | ||
emptyViewImage = view.findViewById<ImageView>(R.id.image_view) as ImageView | ||
emptyTitleView = view.findViewById<TextView>(R.id.empty_title) as TextView | ||
emptyDescView = view.findViewById<TextView>(R.id.empty_description) as TextView | ||
emptyTitleView.typeface = TestpressSdk.getRubikMediumFont(requireContext()) | ||
emptyDescView.typeface = TestpressSdk.getRubikRegularFont(requireContext()) | ||
retryButton = view.findViewById<Button>(R.id.retry_button) as Button | ||
progressBar = view.findViewById<ProgressBar>(R.id.pb_loading) as ProgressBar | ||
UIUtils.setIndeterminateDrawable(activity, progressBar, 4) | ||
carouselView.visibility = View.GONE | ||
retryButton.setOnClickListener { | ||
emptyView.visibility = View.GONE | ||
loadMyReputation() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use View binding
PruthiviRaj27
force-pushed
the
refactorleaderboard
branch
from
January 3, 2023 06:19
7c3df36
to
eb54784
Compare
PruthiviRaj27
force-pushed
the
refactorleaderboard
branch
from
January 6, 2023 14:03
eb54784
to
eaef741
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes done
Fixes #.