Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactor RegisterActivity #157

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SangeethaTestPress
Copy link
Contributor

Changes done

  • Refactored RegisterActivity which employs android guidance.

import javax.inject.Inject
import kotlin.collections.HashMap

class RegisterActivity : AppCompatActivity() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

private val instituteSettingsDao: InstituteSettingsDao = daoSession.instituteSettingsDao
private var internetConnectivityChecker = InternetConnectivityChecker(this)
private lateinit var viewModel: RegisterViewModel
private var userDetails = HashMap<String,String>()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

}).get(RegisterViewModel::class.java)
}

private fun getVerificationMethod() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

isTwilioEnabled = instituteSettingsList[0].twilioEnabled
}

private fun setViewVisibility() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

}

private fun setCountryCodePicker() {
if (isTwilioEnabled) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

image

import javax.inject.Inject
import kotlin.collections.HashMap

class RegisterActivity : AppCompatActivity() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

image

}
}

private var isValid = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misplaced

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants