-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Refactor RegisterActivity #157
base: master
Are you sure you want to change the base?
Conversation
app/src/main/java/in/testpress/testpress/authenticator/RegisterActivity.kt
Show resolved
Hide resolved
import javax.inject.Inject | ||
import kotlin.collections.HashMap | ||
|
||
class RegisterActivity : AppCompatActivity() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
private val instituteSettingsDao: InstituteSettingsDao = daoSession.instituteSettingsDao | ||
private var internetConnectivityChecker = InternetConnectivityChecker(this) | ||
private lateinit var viewModel: RegisterViewModel | ||
private var userDetails = HashMap<String,String>() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
}).get(RegisterViewModel::class.java) | ||
} | ||
|
||
private fun getVerificationMethod() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isTwilioEnabled = instituteSettingsList[0].twilioEnabled | ||
} | ||
|
||
private fun setViewVisibility() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} | ||
|
||
private fun setCountryCodePicker() { | ||
if (isTwilioEnabled) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import javax.inject.Inject | ||
import kotlin.collections.HashMap | ||
|
||
class RegisterActivity : AppCompatActivity() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} | ||
} | ||
|
||
private var isValid = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Misplaced
c686873
to
f9b09e8
Compare
Changes done