improve messages in specified to prefer "dearu" or "desumasu" #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azu
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
このPRは
"である"または"ですます"を明示的に指定した場合のエラーメッセージを改善します。
closes #49
改善方針
メッセージ生成部分において、"である"調向けと"ですます"調向けの判定による分岐だけでなく「優先指定がされているかどうか」も分岐として加えました。
また、従来の
if文中で直接returnする書き方だと、コピペっぽいコードが4つも並んでしまい不格好だったため、Total:以下の共通箇所を切り出し、最後にreturnするようにしました。テスト
テストケースも修正し、パスできていることは確認しています。