Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

BUGFIX: undirected clustering for weighted directed networks and from_matrix #112

Merged
merged 7 commits into from
Sep 18, 2020
Merged

BUGFIX: undirected clustering for weighted directed networks and from_matrix #112

merged 7 commits into from
Sep 18, 2020

Conversation

Silmathoron
Copy link
Collaborator

Fixes #111 by properly computing or renormalizing the weighted undirected matrix.

@coveralls
Copy link

coveralls commented Sep 17, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 71.342% when pulling 5159a1e on fix-undir-clst into 3020f73 on master.

@Silmathoron Silmathoron marked this pull request as draft September 17, 2020 21:29
@Silmathoron Silmathoron marked this pull request as ready for review September 18, 2020 07:11
@Silmathoron
Copy link
Collaborator Author

This PR now also fixes #114

@Silmathoron Silmathoron linked an issue Sep 18, 2020 that may be closed by this pull request
Wrong graph generated from undirected matrices #114
Closed
@Silmathoron Silmathoron changed the title BUGFIX: undirected clustering for weighted directed networks BUGFIX: undirected clustering for weighted directed networks and from_matrix Sep 18, 2020
@Silmathoron Silmathoron merged commit 236027d into master Sep 18, 2020
@Silmathoron Silmathoron deleted the fix-undir-clst branch November 26, 2020 16:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
algorithms bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong graph generated from undirected matrices Incorrect undirected matrix for clustering
2 participants
@Silmathoron @coveralls