Add auth extension for django-rest-knox #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callumgare
force-pushed
the
add-auth-extention-for-django-rest-knox
branch
from
f97d945 to
624c9b9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1163 +/- ##
=======================================
Coverage 98.58% 98.59%
=======================================
Files 72 74 +2
Lines 8771 8802 +31
=======================================
+ Hits 8647 8678 +31
Misses 124 124 ☔ View full report in Codecov by Sentry. |
|
@callumgare excellent! Thank you very much for the PR. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a security schema extension for https://github.com/jazzband/django-rest-knox. Based off #264
It's my first time contributing and I've done my best to follow CONTRIBUTING.rst but I wasn't 100% about all the conventions with the tests so apologies it's it's a bit off.