support snapshot option 'invalidate_hard_deletes' #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
invalidate_hard_deletes
which marks records missing in the source as deleted in the snapshotTests
I tested snapshots manually both with and without the new configuration option
invalidate_hard_deletes
enabled.Step 0: One row (
![Screenshot 2022-05-31 at 3 09 38 PM](https://user-images.githubusercontent.com/217980/171170438-c713aa71-3b32-47c4-b630-8febca62cd15.png)
id = 1
) is present in the sourceStep 1: A second row (
![Screenshot 2022-05-31 at 3 11 03 PM](https://user-images.githubusercontent.com/217980/171170527-f8087b66-f6d0-4d2d-b6d4-4523dbaf1c29.png)
id = 2
) is present in the sourceStep 2: The first row (
![Screenshot 2022-05-31 at 5 38 56 PM](https://user-images.githubusercontent.com/217980/171170867-052c7fb2-d3ff-461a-bcd3-73a000f4aaae.png)
id = 1
) is deleted in the source. Thus, valid_to is set by thedbt snapshot
runStep 3: The first row (
![Screenshot 2022-05-31 at 5 39 56 PM](https://user-images.githubusercontent.com/217980/171171000-3bb9452f-cd30-4f3d-81bf-a1f329c52949.png)
id = 1
) appears again in the source. Thus, it is added to the snapshot as a valid rowStep 4: The second row (
![Screenshot 2022-05-31 at 5 40 54 PM](https://user-images.githubusercontent.com/217980/171171078-4a8f8a4b-d643-4bbe-9b78-61f872e0f703.png)
id = 2
) changes its value toval = 'v2'
. Thus, the old record is is marked as valid_until und a new row for the current value is appended to the snapshot.Thus it has been demonstrated that this PR satisfies the following cases:
Background
This PR aims to follow the code from dbt-core as seen here and here