Not allow keyin all space.

thape-cn · Dec 17, 2024 · 3b71956 · 3b71956
1 parent 283322f
commit 3b71956
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/app/controllers/staff/mark_scores_controller.rb b/app/controllers/staff/mark_scores_controller.rb
@@ -240,7 +240,9 @@ def build_table_headers_of_capability(headers_of_capability, headers_of_performa
     def check_mark_score_completion(need_review_evaluations, job_role_evaluation_performances)
       all_overall_not_valid_eucs = need_review_evaluations.find_all do |euc|
         euc.manager_overall_improvement&.length.to_i < 20 \
-        || euc.manager_overall_plan&.length.to_i < 20
+        || euc.manager_overall_plan&.length.to_i < 20 \
+        || euc.manager_overall_improvement&.strip&.empty? \
+        || euc.manager_overall_plan&.strip&.empty?
       end
       Rails.logger.debug "all_overall_not_valid_eucs: #{all_overall_not_valid_eucs}"